Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdksync - "(CAT-1618) - Add code coverage to ci" #540

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

jordanbreen28
Copy link
Contributor

"(CAT-1618) - Add code coverage to ci"
pdk version: 3.0.0

@jordanbreen28 jordanbreen28 requested a review from a team as a code owner January 15, 2024 14:00
@jordanbreen28 jordanbreen28 force-pushed the pdksync_"cat-1618-add_code_cov" branch from f31e234 to 41ee7ab Compare January 15, 2024 14:16
@jordanbreen28 jordanbreen28 force-pushed the pdksync_"cat-1618-add_code_cov" branch from 41ee7ab to 44c53af Compare January 15, 2024 14:19
@codecov-commenter
Copy link

Codecov Report

Attention: 64 lines in your changes are missing coverage. Please review.

Comparison is base (8db22fd) 64.66% compared to head (44c53af) 61.64%.
Report is 157 commits behind head on main.

Files Patch % Lines
lib/puppet_litmus/puppet_helpers.rb 77.02% 34 Missing ⚠️
lib/puppet_litmus/rake_tasks.rb 15.00% 17 Missing ⚠️
lib/puppet_litmus/rake_helper.rb 85.52% 11 Missing ⚠️
lib/puppet_litmus/inventory_manipulation.rb 85.71% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #540      +/-   ##
==========================================
- Coverage   64.66%   61.64%   -3.02%     
==========================================
  Files           7        6       -1     
  Lines         917      764     -153     
==========================================
- Hits          593      471     -122     
+ Misses        324      293      -31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@LukasAud LukasAud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LukasAud LukasAud merged commit 3344ed3 into main Jan 15, 2024
4 checks passed
@LukasAud LukasAud deleted the pdksync_"cat-1618-add_code_cov" branch January 15, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants